feat: Allow to sort logs by timestamp in ASC direction #787
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR enables sorting logs by timestamp in ascending order by introducing an order state and a toggle mechanism in the log table header.
- Added order and setOrder props in RawLogTable and updated prop types
- Updated the timestamp header to support toggling sort order (while ensuring live mode always remains in descending order)
- Propagated the order property to affect caching (resultsKey) and child components
Files not reviewed (1)
- packages/app/styles/LogTable.module.scss: Language not supported
| ? 'Time' | ||
| : `Timestamp${isUTC ? ' (UTC)' : ' (Local)'}`, | ||
| header: () => ( | ||
| <div |
There was a problem hiding this comment.
Consider adding role="button" and keyboard event support (e.g., onKeyDown) to the clickable header div for improved accessibility.
| <div | |
| <div | |
| role="button" | |
| tabIndex={0} |
Copilot uses AI. Check for mistakes.
ernestii
force-pushed
the
ernest/hdx-1449-v1-feat-option-to-order-by-timestamp-in-the-asc-direction
branch
from
4ec13e3 to
8b030f4
Compare
ernestii
force-pushed
the
ernest/hdx-1449-v1-feat-option-to-order-by-timestamp-in-the-asc-direction
branch
from
8b030f4 to
9828308
Compare
|
Note: PR jobs are failing due to an outdated ubuntu runner that has been deprecated. Fix is here: #792 |
…imestamp-in-the-asc-direction
kodiakhq
bot
deleted the
ernest/hdx-1449-v1-feat-option-to-order-by-timestamp-in-the-asc-direction
branch
Allow to sort logs by timestamp in ASC direction.
Screen.Recording.2025-05-01.at.8.10.04.PM.mov